Skip to content

Remove old support for reading annotations from bytecode - #1661

Draft
msridhar wants to merge 1 commit into
masterfrom
remove-old-bytecode-reading-support
Draft

Remove old support for reading annotations from bytecode#1661
msridhar wants to merge 1 commit into
masterfrom
remove-old-bytecode-reading-support

Conversation

@msridhar

@msridhar msridhar commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1639. Leaving this as draft until we decide when we want to land it.

@msridhar

Copy link
Copy Markdown
Collaborator Author

This change is part of the following stack:

Change managed by git-spice.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.93%. Comparing base (f3f7c9b) to head (cb6a545).

Files with missing lines Patch % Lines
...c/main/java/com/uber/nullaway/NullabilityUtil.java 96.96% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1661      +/-   ##
============================================
+ Coverage     87.89%   87.93%   +0.04%     
+ Complexity     3173     3138      -35     
============================================
  Files           109      109              
  Lines         10755    10703      -52     
  Branches       2173     2151      -22     
============================================
- Hits           9453     9412      -41     
+ Misses          617      615       -2     
+ Partials        685      676       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.485 ± 0.066  ops/s
CaffeineBenchmark.compile         thrpt   25   2.277 ± 0.021  ops/s
DFlowMicroBenchmark.compile       thrpt   25  41.020 ± 0.232  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.643 ± 0.027  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.438 ± 0.065  ops/s
CaffeineBenchmark.compile         thrpt   25   2.279 ± 0.021  ops/s
DFlowMicroBenchmark.compile       thrpt   25  41.324 ± 0.270  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.639 ± 0.017  ops/s

@msridhar
msridhar force-pushed the remove-old-bytecode-reading-support branch 3 times, most recently from 8a8de53 to a74e5d6 Compare August 10, 2026 20:54
@msridhar
msridhar force-pushed the remove-old-bytecode-reading-support branch from a74e5d6 to cb6a545 Compare August 11, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old workaround code for reading type use annotations from bytecode

1 participant